Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Updating communicating expectations PR rule #7198

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Conversation

GordonBeeming
Copy link
Member

@GordonBeeming GordonBeeming commented Nov 7, 2023

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ I noticed the example on the rule was outdated and not referenced from writing great PRs

  1. What was changed?

✏️ Added a related rule from writing great PRs to communicating expectations rule
✏️ Added a link to a great pr template (ours in the template repo)
✏️ Added a good example (current good went to being ok)

  1. Did you do pair or mob programming?

✏️ No

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 7
Total 7

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Updating communicating expectations PR rule XS✔ ◾ Updating communicating expectations PR rule Nov 7, 2023
@bradystroud bradystroud merged commit c4927fa into main Nov 7, 2023
6 checks passed
@bradystroud bradystroud deleted the prs-16 branch November 7, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants