Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Update Rule - bug fixes and semantic changes #7367

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

Dhruv-0987
Copy link
Contributor

@Dhruv-0987 Dhruv-0987 commented Nov 29, 2023

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ The rule was reviewed by Tiago and he suggested the changes.

  1. What was changed?

✏️ The uri and the rule path in github was mismatching, which was changed and some semantic changes for better readabillity.

  1. Did you do pair or mob programming (and list names)?

✏️ No

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Nov 29, 2023
Copy link
Contributor

Hi @Dhruv-0987,

There were some Markdown Linting Errors in your pull request:

File Error Rule
rules/integrate-identityserver-with-an-existing-user-store/rule.md Line 70 MD024/no-duplicate-heading/no-duplicate-header Multiple headings with the same content [Context: headings with the same content Rule MD024

Please review the errors and update your Markdown files accordingly.

Copy link
Contributor

github-actions bot commented Nov 29, 2023

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 14
Total 14

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Update Rule - bug fixes and semantic changes XS✔ ◾ Update Rule - bug fixes and semantic changes Nov 29, 2023
@JackDevAU JackDevAU merged commit 38e9f86 into main Nov 30, 2023
@JackDevAU JackDevAU deleted the Dhruv-0987-patch-Tiago's-suggestions branch November 30, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants