Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Update rule.md #7391

Merged
merged 2 commits into from
Dec 4, 2023
Merged

XS✔ ◾ Update rule.md #7391

merged 2 commits into from
Dec 4, 2023

Conversation

tkapa
Copy link
Member

@tkapa tkapa commented Dec 1, 2023

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Adam provided some feedback on the v1 of the Rule, and I think that it worked perfectly as a good example.

  1. What was changed?
  • Added @adamcogan and @tiagov8 as Authors
  • Updated good and bad examples to Teams images
  • Trimmed unnecessary content

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 7
Total 7

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Update rule.md XS✔ ◾ Update rule.md Dec 1, 2023
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old and removed Age: 🥚 - New About 2 hours old labels Dec 1, 2023
@tiagov8
Copy link
Member

tiagov8 commented Dec 1, 2023

Hi @tkapa

I see you updated grayboxes with images, but I don't see the new images uploaded in the PR...
Can you make sure the images are included to avoid broken images?

@github-actions github-actions bot added Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 2, 2023

Howzit @tkapa,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@JackDevAU JackDevAU self-requested a review December 3, 2023 22:59
@tkapa
Copy link
Member Author

tkapa commented Dec 3, 2023

Hi @tkapa

I see you updated grayboxes with images, but I don't see the new images uploaded in the PR... Can you make sure the images are included to avoid broken images?

Hey @tiagov8,

Yes of course! I've updated the rule and added the actual images to the repo.

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Dec 4, 2023
@UlyssesMaclaren UlyssesMaclaren merged commit e7908ce into main Dec 4, 2023
5 checks passed
@UlyssesMaclaren UlyssesMaclaren deleted the tkapa-patch-1 branch December 4, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🦖 - Extinct About 128 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants