Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Improved headings /migrate-an-existing-user-store-to-an-externalauthp… #7421

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

tiagov8
Copy link
Member

@tiagov8 tiagov8 commented Dec 4, 2023

cc @Dhruv-0987

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Myself

  1. What was changed?

Headings syntax and capitalization and wording

  1. Did you do pair or mob programming (list names)?

No

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 15
Total 15

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Improved headings /migrate-an-existing-user-store-to-an-externalauthp… XS✔ ◾ Improved headings /migrate-an-existing-user-store-to-an-externalauthp… Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/migrate-an-existing-user-store-to-an-externalauthprovider/rule.md Line 28 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001
rules/migrate-an-existing-user-store-to-an-externalauthprovider/rule.md Line 74 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001
rules/migrate-an-existing-user-store-to-an-externalauthprovider/rule.md Line 111 MD024/no-duplicate-heading/no-duplicate-header Multiple headings with the same content [Context: headings with the same content Rule MD024
rules/migrate-an-existing-user-store-to-an-externalauthprovider/rule.md Line 119 MD024/no-duplicate-heading/no-duplicate-header Multiple headings with the same content [Context: headings with the same content Rule MD024

Please review the errors and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Dec 4, 2023
Copy link
Contributor

@Dhruv-0987 Dhruv-0987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions github-actions bot added the 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ label Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Howzit @tiagov8,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@UlyssesMaclaren UlyssesMaclaren merged commit d1bb719 into main Dec 6, 2023
6 of 7 checks passed
@UlyssesMaclaren UlyssesMaclaren deleted the tiagov8-patch-5 branch December 6, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants