Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ CodeAuditor Scan - Fix JK's broken image #7456

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

tombui99
Copy link
Contributor

@tombui99 tombui99 commented Dec 6, 2023

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Latest CodeAuditor scan on SSW Rules detected JK's broken image
See https://codeauditor.com/build/1abe83e7-dd21-480d-9e78-9e3e39ce3f1e

  1. What was changed?

Removed "(JK)" to match his name in SSW People Profile

  1. Did you do pair or mob programming (list names)?

No

@tombui99 tombui99 added the codeauditor fix Fixes from CodeAuditor reports label Dec 6, 2023
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 6
Total 6

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title CodeAuditor Scan - Fix JK's broken image XS✔ ◾ CodeAuditor Scan - Fix JK's broken image Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Hi @tombui99,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/migrating-web-apps/rule.md Line 29 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: top-level headings in the same document Rule MD025
rules/migrating-web-apps/rule.md Line 41 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001

Please review the errors and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old labels Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Hi @tombui99,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/migrating-web-apps/rule.md Line 105 MD036/no-emphasis-as-heading/no-emphasis-as-header Emphasis used instead of a heading [Context: used instead of a heading Rule MD036

Please review the errors and update your Markdown files accordingly.

@tiagov8 tiagov8 merged commit 403bf8e into main Dec 6, 2023
4 of 5 checks passed
@tiagov8 tiagov8 deleted the tombui99-patch-1 branch December 6, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🐥 - Adolescent About 8 hours old codeauditor fix Fixes from CodeAuditor reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants