Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Update rule.md - added Key vault on premise options in pros. #7470

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

Dhruv-0987
Copy link
Contributor

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ This was pointed out in a discussion with Matt W as part of the SugarLearning item: https://my.sugarlearning.com/SSW/items/13056

  1. What was changed?

✏️ Added another pro point for Key Vault - Can be used for on premise.

  1. Did you do pair or mob programming (list names)?

✏️ Consulted @wicksipedia

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 9
Total 9

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Update rule.md - added Key vault on premise options in pros. XS✔ ◾ Update rule.md - added Key vault on premise options in pros. Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Hi @Dhruv-0987,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/store-your-secrets-securely/rule.md Line 53: should have alternate text (alt text) Rule MD045
rules/store-your-secrets-securely/rule.md Line 225: should have alternate text (alt text) Rule MD045

Please review the errors and update your Markdown files accordingly.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Hi @Dhruv-0987,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/store-your-secrets-securely/rule.md Line 53: should have alternate text (alt text) Rule MD045
rules/store-your-secrets-securely/rule.md Line 225: should have alternate text (alt text) Rule MD045

Please review the errors and update your Markdown files accordingly.

@Dhruv-0987 Dhruv-0987 merged commit 244a8d4 into main Dec 7, 2023
4 of 5 checks passed
@Dhruv-0987 Dhruv-0987 deleted the Dhruv-0987-patch-1 branch December 7, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants