Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Add placeholder rule for novated leases #7535

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Conversation

bradystroud
Copy link
Member

@bradystroud bradystroud commented Dec 13, 2023

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

This link is being used in a video, so i made a placeholder rule.
Also fixed the url for the other sal sac rule

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ convo with Adam

  1. What was changed?

✏️ made a placeholder rule

  1. Did you do pair or mob programming (list names)?

✏️

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Dec 13, 2023
Copy link
Contributor

github-actions bot commented Dec 13, 2023

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 26
Total 26

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Add placeholder rule for novated leases XS✔ ◾ Add placeholder rule for novated leases Dec 13, 2023
Copy link
Contributor

Hi @bradystroud,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/salary-sacrifice-electronic-devices/rule.md Line 72 MD036/no-emphasis-as-heading Emphasis used instead of a heading [Context: used instead of a heading Rule MD036

Please review the errors and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Dec 13, 2023
@bradystroud bradystroud merged commit 86b42c2 into main Dec 13, 2023
2 of 5 checks passed
@bradystroud bradystroud deleted the novated-lease branch December 13, 2023 22:27
Copy link
Contributor

Hi @,

Please fix the Frontmatter in your Markdown files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🐤 - Mature About 16 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants