Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Removing "as per our conversation" as related rule due to redundancy #7574

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

BenDunkerleySSW
Copy link
Member

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Email Subject: Salary terminology rule - remove duplicate link

  1. What was changed?

removed the "as per our conversation" rule from related rules as it was already mentioned in the content body. Therefore was a duplicate

  1. Did you do pair or mob programming (list names)?

No.

Copy link
Member

@sethdaily sethdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @bradystroud
Are you sure we don't leave them in the related section?

@sethdaily sethdaily merged commit c15fc62 into main Dec 15, 2023
5 checks passed
@sethdaily sethdaily deleted the BenDunkerleySSW-patch-1 branch December 15, 2023 00:39
Copy link
Contributor

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 0
Total 0

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Removing "as per our conversation" as related rule due to redundancy XS✔ ◾ Removing "as per our conversation" as related rule due to redundancy Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants