Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ 🚚 Migrated rule - Do you show errors in Red? #7580

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

jeoffreyfischer
Copy link
Member

@jeoffreyfischer jeoffreyfischer commented Dec 15, 2023

What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️Migrated as per SSWConsulting/SSW.Website#1841

What was changed?

✏️Nothing

Did you do pair or mob programming (list names)?

✏️I worked with @GordonBeeming and @adamcogan

@jeoffreyfischer jeoffreyfischer self-assigned this Dec 15, 2023
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Dec 15, 2023
Copy link
Contributor

Hi @jeoffreyfischer,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/show-errors-in-red/rule.md Line 44: list item prefix Rule MD029
rules/show-errors-in-red/rule.md Line 46 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: code blocks should have a language specified Rule MD040
rules/show-errors-in-red/rule.md Line 54: list item prefix Rule MD029
rules/show-errors-in-red/rule.md Line 56: list item prefix Rule MD029
rules/show-errors-in-red/rule.md Line 58 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: code blocks should have a language specified Rule MD040

Please review and update your Markdown files accordingly.

Copy link
Contributor

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 63
Total 63

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Migrated rule - Do you show errors in Red? XS✔ ◾ Migrated rule - Do you show errors in Red? Dec 15, 2023
Copy link
Member

@sethdaily sethdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots look very old...should they be updated

Copy link
Contributor

Hi @jeoffreyfischer,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/show-errors-in-red/rule.md Line 44: list item prefix Rule MD029
rules/show-errors-in-red/rule.md Line 46 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: code blocks should have a language specified Rule MD040
rules/show-errors-in-red/rule.md Line 54: list item prefix Rule MD029
rules/show-errors-in-red/rule.md Line 56: list item prefix Rule MD029
rules/show-errors-in-red/rule.md Line 58 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: code blocks should have a language specified Rule MD040

Please review and update your Markdown files accordingly.

Copy link
Contributor

Hi @jeoffreyfischer,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/show-errors-in-red/rule.md Line 44: list item prefix Rule MD029
rules/show-errors-in-red/rule.md Line 54: list item prefix Rule MD029
rules/show-errors-in-red/rule.md Line 56: list item prefix Rule MD029
rules/show-errors-in-red/rule.md Line 58 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: code blocks should have a language specified Rule MD040

Please review and update your Markdown files accordingly.

@sethdaily sethdaily merged commit af010a5 into main Dec 15, 2023
4 of 5 checks passed
@sethdaily sethdaily deleted the show-errors-in-red branch December 15, 2023 04:07
@jeoffreyfischer jeoffreyfischer changed the title XS✔ ◾ Migrated rule - Do you show errors in Red? XS✔ ◾ 🚚 Migrated rule - Do you show errors in Red? Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants