Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Archived rule - fix broken link #7594

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

wicksipedia
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ I clicked on the link to the updated rule and it 404'd

  1. What was changed?

✏️ the link to the new rule

  1. Did you do pair or mob programming (list names)?

✏️ no

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Dec 18, 2023
@wicksipedia
Copy link
Member Author

Hey @tiagov8, I noticed that you archived the rule initially pls.
Just an fyi that the url was pointing the root of ssw.com.au and not inside the /rules route

Copy link
Contributor

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 1
Total 1

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Archived rule - fix broken link XS✔ ◾ Archived rule - fix broken link Dec 18, 2023
@wicksipedia
Copy link
Member Author

Hey @BrookJeynes, I noticed you changed this page recently to fix CodeAuditor broken links.
I'm guessing that it didn't report this specific link - any feedback for improving CodeAuditor to help find/fix these?

@wicksipedia wicksipedia merged commit aef9132 into main Dec 18, 2023
7 checks passed
@wicksipedia wicksipedia deleted the wicksipedia-patch-1 branch December 18, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants