Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ Update cross platform UI Tests for Xamarin rule #7824

Merged
merged 4 commits into from
Feb 20, 2024
Merged

XS✔ ◾ Update cross platform UI Tests for Xamarin rule #7824

merged 4 commits into from
Feb 20, 2024

Conversation

AntPolkanov
Copy link
Member

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️

  1. What was changed?

✏️

  1. Did you do pair or mob programming (list names)?

✏️

@AntPolkanov AntPolkanov self-assigned this Jan 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024 •
edited
Loading

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 5
Total 5

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Archive cross platform UI Tests for Xamarin rule XS✔ ◾ Archive cross platform UI Tests for Xamarin rule Jan 24, 2024
@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Jan 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Howzit @AntPolkanov,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Jan 26, 2024
matt-goldman
matt-goldman suggested changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@matt-goldman matt-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with this. There is guidance from Microsoft on using AutomationId and Repl, just not in the product docs.

@AntPolkanov AntPolkanov enabled auto-merge (squash) February 4, 2024 22:48
@tiagov8
Copy link
Member

tiagov8 commented Feb 9, 2024 •
edited by AntPolkanov
Loading

Hi @AntPolkanov

This PR has been here for a while.

@AntPolkanov AntPolkanov changed the title XS✔ ◾ Archive cross platform UI Tests for Xamarin rule XS✔ ◾ Update cross platform UI Tests for Xamarin rule Feb 20, 2024
matt-goldman
matt-goldman approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@matt-goldman matt-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 LGTM

@AntPolkanov AntPolkanov merged commit 312a7d7 into main Feb 20, 2024
@AntPolkanov AntPolkanov deleted the archive-maui-ui-tests-rule branch February 20, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-goldman matt-goldman matt-goldman approved these changes

Assignees

@AntPolkanov AntPolkanov

Labels
Age: 🦖 - Extinct About 128 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntPolkanov @tiagov8 @matt-goldman