Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ CodeAuditor - Fixed absolute internal links #7829

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

tombui99
Copy link
Contributor

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Latest CodeAuditor scan detected these pages that use absolute internal links.

See scan details https://codeauditor.com/htmlhint/00131182-1996-42cc-882e-01850d65a5d6

To comply with Rule https://www.ssw.com.au/rules/avoid-absolute-internal-links/

  1. What was changed?

Removed absolute internal links

  1. Did you do pair or mob programming (list names)?

No

@tombui99 tombui99 added the codeauditor fix Fixes from CodeAuditor reports label Jan 24, 2024
@tombui99 tombui99 requested a review from tiagov8 January 24, 2024 04:29
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Jan 24, 2024
Copy link
Contributor

github-actions bot commented Jan 24, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 4
Total 4

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title CodeAuditor - Fixed absolute internal links XS✔ ◾ CodeAuditor - Fixed absolute internal links Jan 24, 2024
Copy link
Contributor

Hi @tombui99,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/linkedin-profile/rule.md Line 29: list item prefix Rule MD029
rules/linkedin-profile/rule.md Line 30: list item prefix Rule MD029

Please review and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Jan 24, 2024
@tiagov8 tiagov8 merged commit 612382e into main Jan 24, 2024
@tiagov8 tiagov8 deleted the fix-absolute-internal-links branch January 24, 2024 19:32
Copy link
Contributor

Hi @,

Please fix the Frontmatter in your Markdown files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🐤 - Mature About 16 hours old codeauditor fix Fixes from CodeAuditor reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants