New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule - Do you know how to allocate the expenses to the offices? #7832

Merged

tiagov8 merged 12 commits into SSWConsulting:main from JimmyChenSSW:main

Jan 26, 2024

Contributor

JimmyChenSSW commented Jan 24, 2024

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

A task from @stephanfakossw that create a rule to explain how we allocate expenses to different offices.

What was changed?

New rule created
Update the category of better accounting

Did you do pair or mob programming (list names)?

@stephanfakossw

JimmyChenSSW added 3 commits

January 25, 2024 10:42


          Create rule.md

b1f1120


          Add files via upload

b2958c0


          Update rules-to-better-accounting.md

d2d9a3d

sethdaily reviewed

View reviewed changes

rules/allocate-the-expenses-to-the-offices/rule.md Outdated Show resolved Hide resolved

sethdaily reviewed

View reviewed changes

rules/allocate-the-expenses-to-the-offices/rule.md Outdated Show resolved Hide resolved

sethdaily reviewed

View reviewed changes

rules/allocate-the-expenses-to-the-offices/rule.md Outdated Show resolved Hide resolved

sethdaily reviewed

View reviewed changes

rules/allocate-the-expenses-to-the-offices/rule.md Outdated Show resolved Hide resolved

sethdaily reviewed

View reviewed changes

rules/allocate-the-expenses-to-the-offices/rule.md Outdated Show resolved Hide resolved

sethdaily previously requested changes

View reviewed changes

Member

sethdaily left a comment

See comments
I would change the title from:
Do you know how to allocate the expenses to the offices?
to
Do you know how to allocate expenses per office?

github-actions bot added the Age: 🥚 - New label

JimmyChenSSW and others added 6 commits

January 25, 2024 12:28


          Update rules/allocate-the-expenses-to-the-offices/rule.md

d8e88bd

Co-authored-by: Seth Daily [SSW] <[email protected]>


          Update rules/allocate-the-expenses-to-the-offices/rule.md

Co-authored-by: Seth Daily [SSW] <[email protected]>


          Update rules/allocate-the-expenses-to-the-offices/rule.md

7508bd3

Co-authored-by: Seth Daily [SSW] <[email protected]>


          Update rules/allocate-the-expenses-to-the-offices/rule.md

f11d220

Co-authored-by: Seth Daily [SSW] <[email protected]>


          Add files via upload

c38dc16


          Update rule.md

ac8d9b7

github-actions bot added Age: 🐣 - Young and removed Age: 🥚 - New labels

JimmyChenSSW added 2 commits

January 25, 2024 13:31


          Update and rename rule.md to rule.md

496a922


          Update rules-to-better-accounting.md

e204c89

JimmyChenSSW commented

View reviewed changes

Contributor Author

JimmyChenSSW left a comment

Changed as per suggested by Seth

JimmyChenSSW requested a review from sethdaily

January 25, 2024 02:33

github-actions bot added Age: 🐥 - Adolescent Age: 🐤 - Mature Age: 🐓 - Old Age: 🍗 - Ancient and removed Age: 🐣 - Young Age: 🐥 - Adolescent Age: 🐤 - Mature Age: 🐓 - Old labels

github-actions bot added the 🔥 Merge Debt label

Contributor

github-actions bot commented Jan 26, 2024

Howzit @JimmyChenSSW,

This PR has been here a while.

Did you know you should avoid merge debt?

Please action (e.g. get a review) and merge or close

Thanks!


          Update rule.md

6dfad17

tiagov8 approved these changes

View reviewed changes

tiagov8 dismissed sethdaily’s stale review

January 26, 2024 19:36

done

tiagov8 merged commit e3d6b9e into SSWConsulting:main

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Age: 🍗 - Ancient 🔥 Merge Debt