Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ CodeAuditor - Fix absolute internal path #7876

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

tombui99
Copy link
Contributor

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Latest CodeAuditor scan detected absolute internal path in this Rule.

To comply with rule https://www.ssw.com.au/rules/avoid-absolute-internal-links/

See scan details https://codeauditor.com/htmlhint/534c8d07-9d4d-45be-a3e3-760b81bfdab7

  1. What was changed?

Removed absolute internal path

  1. Did you do pair or mob programming (list names)?

No

@tombui99 tombui99 added the codeauditor fix Fixes from CodeAuditor reports label Jan 31, 2024
@tombui99 tombui99 requested a review from tiagov8 January 31, 2024 00:50
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Jan 31, 2024
Copy link
Contributor

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 1
Total 1

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title CodeAuditor - Fix absolute internal path XS✔ ◾ CodeAuditor - Fix absolute internal path Jan 31, 2024
Copy link
Contributor

Hi @tombui99,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/linkedin-profile/rule.md Line 43: list item prefix Rule MD029

Please review and update your Markdown files accordingly.

@tiagov8 tiagov8 merged commit b4e3bb5 into main Jan 31, 2024
6 of 7 checks passed
@tiagov8 tiagov8 deleted the tombui99-patch-1 branch January 31, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🥚 - New About 2 hours old codeauditor fix Fixes from CodeAuditor reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants