Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ 🐛 Fix Duplicate Image Name #7938

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

Aibono1225
Copy link
Member

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ As described in this issue SSWConsulting/SSW.Rules#1163 (comment), the duplicated image name will cause a rendering bug.

  1. What was changed?

✏️ Rename image to prevent duplicating

  1. Did you do pair or mob programming (list names)?

✏️ No

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Hi @Aibono1225,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/azure-devops-permissions/rule.md Line 30: list item prefix Rule MD029
rules/do-you-use-gzip/rule.md Line 38: should have alternate text (alt text) Rule MD045
rules/do-you-use-optinmonster-for-your-content-downloads/rule.md Line 23: should have alternate text (alt text) Rule MD045
rules/how-to-install-skypepop/rule.md Line 37: list item prefix Rule MD029
rules/how-to-install-skypepop/rule.md Line 41: list item prefix Rule MD029
rules/how-to-install-skypepop/rule.md Line 43: list item prefix Rule MD029
rules/how-to-install-skypepop/rule.md Line 55: list item prefix Rule MD029
rules/how-to-install-skypepop/rule.md Line 63: list item prefix Rule MD029
rules/how-to-install-skypepop/rule.md Line 67: list item prefix Rule MD029
rules/how-to-install-skypepop/rule.md Line 71: list item prefix Rule MD029
rules/how-to-install-skypepop/rule.md Line 73: list item prefix Rule MD029
rules/how-to-install-skypepop/rule.md Line 77: list item prefix Rule MD029
rules/how-to-install-skypepop/rule.md Line 85: list item prefix Rule MD029
rules/how-to-install-skypepop/rule.md Line 87: list item prefix Rule MD029
rules/linkedin-creator-mode/rule.md Line 45: list item prefix Rule MD029
rules/linkedin-creator-mode/rule.md Line 46: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 49: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 53: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 57: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 61: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 71: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 73: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 87: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 91: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 95: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 99: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 107: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 111: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 119: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 123: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 129: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 153: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 157: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 161: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 165: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 169: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 173: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 177: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 187: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 191: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 201: list item prefix Rule MD029
rules/make-sure-all-software-uses-english/rule.md Line 207: list item prefix Rule MD029
rules/tax-invoice-vs-eftpos-receipt/rule.md Line 21: should have alternate text (alt text) Rule MD045

Please review and update your Markdown files accordingly.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 21
Total 21

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title 🐛 Fix Duplicate Image Name XS✔ ◾ 🐛 Fix Duplicate Image Name Feb 9, 2024
@Aibono1225 Aibono1225 merged commit f5c0179 into main Feb 9, 2024
@Aibono1225 Aibono1225 deleted the fix-duplicate-image-name branch February 9, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants