Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ Update rule.md - Fixing formatting #8009

Merged
merged 38 commits into from
Mar 4, 2024
Merged

XS✔ ◾ Update rule.md - Fixing formatting #8009

merged 38 commits into from
Mar 4, 2024

Conversation

amankumarrr
Copy link
Member

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ Formatting issue

  1. What was changed?

✏️ Added extra space to add the line break

  1. Did you do pair or mob programming (list names)?

✏️ No

amankumarrr and others added 25 commits October 10, 2023 10:39
@amankumarrr
Create rule.md - Mask secrets in GitHub Actions
5835429
@amankumarrr
Update rules-to-better-devops-using-github.md - adding a reference to…
ae5e1a9 
… new rule
@amankumarrr @wicksipedia
Update rules/mask-secrets-in-github-actions/rule.md
a85bfcf 
Co-authored-by: Matt Wicks [SSW] <[email protected]>
@amankumarrr @wicksipedia
Update rules/mask-secrets-in-github-actions/rule.md
7a5afcd 
Co-authored-by: Matt Wicks [SSW] <[email protected]>
@amankumarrr @wicksipedia
Update rules/mask-secrets-in-github-actions/rule.md
0937f16 
Co-authored-by: Matt Wicks [SSW] <[email protected]>
@amankumarrr @wicksipedia
Update categories/software-development/rules-to-better-devops-using-g…
0f60bb0 
…ithub.md

Co-authored-by: Matt Wicks [SSW] <[email protected]>
@amankumarrr @wicksipedia
Update rules/mask-secrets-in-github-actions/rule.md
6ee1936 
Co-authored-by: Matt Wicks [SSW] <[email protected]>
@amankumarrr @wicksipedia
Update rules/mask-secrets-in-github-actions/rule.md
01f1afc 
Co-authored-by: Matt Wicks [SSW] <[email protected]>
@amankumarrr
Update rule.md - adding screenshots
ed290c9
@amankumarrr @wicksipedia
Update rules/mask-secrets-in-github-actions/rule.md
72f6f3e 
Co-authored-by: Matt Wicks [SSW] <[email protected]>
@amankumarrr @wicksipedia
Update rules/mask-secrets-in-github-actions/rule.md
11df314 
Co-authored-by: Matt Wicks [SSW] <[email protected]>
@amankumarrr
Adding screenshots
b872ebb
@amankumarrr
renaming screenshots for consistency and formatting it
e305ba5
@amankumarrr
Create rule.md - Chose correct timezone for your flows
eeb1bc0
@amankumarrr
Merge branch 'amankumarrr-patch-1' of https://github.com/SSWConsultin…
994e1a9 
…g/SSW.Rules.Content into amankumarrr-patch-1
@amankumarrr
Adding screenshot and GIF to show examples
c1036ac
@amankumarrr
Replacing gif with old one
9e0a0fd
@amankumarrr
Renaming the gif image
b0f8df8
@amankumarrr
Update rule.md - fixing broken image
e6640b6
@amankumarrr
Removing old gif
27214ad
@amankumarrr
adding new gif
b742df3
@amankumarrr
Merge branch 'amankumarrr-patch-1' of https://github.com/SSWConsultin…
aef1a04 
…g/SSW.Rules.Content into amankumarrr-patch-1
@amankumarrr
Updating the broken image
b3cac3b
@amankumarrr
Renaming the broken image to right one
88d80e1
@amankumarrr
Update rule.md - Fixing formatting
c9b9ff4
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Feb 26, 2024
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old labels Feb 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2024 •
edited
Loading

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 53
Total 53

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Update rule.md - Fixing formatting XS✔ ◾ Update rule.md - Fixing formatting Feb 27, 2024
@tiagov8
Copy link
Member

tiagov8 commented Feb 27, 2024 •
edited by amankumarrr
Loading

Hi @amankumarrr

@github-actions github-actions bot added Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐓 - Old About 32 hours old labels Feb 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Howzit @amankumarrr,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Feb 29, 2024
sethdaily
sethdaily previously approved these changes Feb 29, 2024
View reviewed changes
@tiagov8
Copy link
Member

tiagov8 commented Mar 1, 2024 •
edited by amankumarrr
Loading

Hey @amankumarrr

Although @sethdaily approved this, it is still set as "draft"... so I dismissed it

  • 1. Please tell me if it's ready for review ;)

@amankumarrr amankumarrr marked this pull request as ready for review March 4, 2024 00:04
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Mar 4, 2024
@sethdaily sethdaily merged commit cf5a47a into main Mar 4, 2024
2 checks passed
@sethdaily sethdaily deleted the amankumarrr-patch-1 branch March 4, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethdaily sethdaily sethdaily approved these changes

@wicksipedia wicksipedia Awaiting requested review from wicksipedia

Assignees
No one assigned
Labels
Age: 🦖 - Extinct About 128 hours old Age: 🥚 - New About 2 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amankumarrr @tiagov8 @sethdaily