Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ ✨ New rule - Successful Reachouts #8038

Merged
merged 9 commits into from
Mar 4, 2024
Merged

XS✔ ◾ ✨ New rule - Successful Reachouts #8038

merged 9 commits into from
Mar 4, 2024

Conversation

bradystroud
Copy link
Member

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

My big brain
Our reachouts could be more successful, i want to document whats worked for me

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Hi @bradystroud,

Rule: ../../rules/successful-reachouts/rule.md

Issues:

  • 'created' must not be empty.

Please fix the Frontmatter in your Markdown files.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 45
Total 45

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title ✨ New rule - Successful Reachouts XS✔ ◾ ✨ New rule - Successful Reachouts Mar 1, 2024
tiagov8
tiagov8 previously requested changes Mar 1, 2024
Copy link
Member

@tiagov8 tiagov8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rules/successful-reachouts/rule.md Outdated Show resolved Hide resolved
rules/successful-reachouts/rule.md Show resolved Hide resolved
rules/successful-reachouts/rule.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 2, 2024

Hi @bradystroud,

Rule: ../../rules/successful-reachouts/rule.md

Issues:

  • 'created' must not be empty.

Please fix the Frontmatter in your Markdown files.

@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Mar 2, 2024
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Howzit @bradystroud,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@sethdaily sethdaily enabled auto-merge (squash) March 3, 2024 22:59
@sethdaily
Copy link
Member

@tiagov8

  1. pls approve your requested changes

Copy link
Contributor

github-actions bot commented Mar 3, 2024

Hi @bradystroud,

Rule: ../../rules/successful-reachouts/rule.md

Issues:

  • 'created' must not be empty.

Please fix the Frontmatter in your Markdown files.

Copy link
Contributor

github-actions bot commented Mar 3, 2024

Hi @bradystroud,

Rule: ../../rules/successful-reachouts/rule.md

Issues:

  • 'created' must not be empty.

Please fix the Frontmatter in your Markdown files.

Copy link
Contributor

github-actions bot commented Mar 3, 2024

Hi @bradystroud,

Rule: ../../rules/successful-reachouts/rule.md

Issues:

  • 'created' must not be empty.

Please fix the Frontmatter in your Markdown files.

@bradystroud bradystroud dismissed tiagov8’s stale review March 4, 2024 07:12

I fixed all Tiagos feedback and have 2 other approvals

@sethdaily sethdaily merged commit ec86719 into main Mar 4, 2024
5 checks passed
@sethdaily sethdaily deleted the reachouts branch March 4, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants