Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Add gap between lines to address Rule MD056 error #8051

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

bettybondoc
Copy link
Member

@tiagov8

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Email: Update Rule - Sending Done Email and Turning Emails to PBI
Pull Request #8024 returned false positives for Rule MD056

  1. What was changed?

As per my conversation with @JackDevAU, I've added a gap between the last row and the following line for each table to see if addresses the issue.

  1. Did you do pair or mob programming (list names)?

No

Copy link
Contributor

github-actions bot commented Mar 4, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 7
Total 7

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Add gap between lines to address Rule MD056 error XS✔ ◾ Add gap between lines to address Rule MD056 error Mar 4, 2024
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Hi @bettybondoc,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/reply-done-and-delete-the-email/rule.md Line 84 MD024/no-duplicate-heading Multiple headings with the same content [Context: headings with the same content Rule MD024
rules/reply-done-and-delete-the-email/rule.md Line 124 MD024/no-duplicate-heading Multiple headings with the same content [Context: headings with the same content Rule MD024
rules/reply-done-and-delete-the-email/rule.md Line 136 MD024/no-duplicate-heading Multiple headings with the same content [Context: headings with the same content Rule MD024
rules/reply-done-and-delete-the-email/rule.md Line 157 MD024/no-duplicate-heading Multiple headings with the same content [Context: headings with the same content Rule MD024
rules/reply-done-and-delete-the-email/rule.md Line 202 MD024/no-duplicate-heading Multiple headings with the same content [Context: headings with the same content Rule MD024
rules/reply-done-and-delete-the-email/rule.md Line 236 MD024/no-duplicate-heading Multiple headings with the same content [Context: headings with the same content Rule MD024

Please review and update your Markdown files accordingly.

@bettybondoc bettybondoc merged commit cf811ca into main Mar 4, 2024
6 of 7 checks passed
@bettybondoc bettybondoc deleted the bettybondoc-patch-2 branch March 4, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants