Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSβœ” β—Ύ πŸ“ Clearer language in disagreeing-with-powerful-stakeholders #8211

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

jaydenalchin
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

CTF

  1. What was changed?

Changed title to be clearer & consistent with slug, small content updates to clarify points and aid readability

Copy link
Contributor

github-actions bot commented Mar 22, 2024

PR Metrics

βœ” Thanks for keeping your pull request small.
βœ” Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 5
Total 5

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title πŸ“ Clearer language in disagreeing-with-powerful-stakeholders XSβœ” β—Ύ πŸ“ Clearer language in disagreeing-with-powerful-stakeholders Mar 22, 2024
Copy link
Contributor

Hi @jaydenalchin,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/disagreeing-with-powerful-stakeholders/rule.md Line 38 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001
rules/disagreeing-with-powerful-stakeholders/rule.md Line 88 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001

Please review and update your Markdown files accordingly.

Copy link
Member

@tiagov8 tiagov8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comment on tip number 2, I am happy with the changes, so approving (but not merging)

rules/disagreeing-with-powerful-stakeholders/rule.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old and removed Age: πŸ₯š - New About 2 hours old labels Mar 22, 2024
Copy link
Contributor

Hi @jaydenalchin,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/disagreeing-with-powerful-stakeholders/rule.md Line 38 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001
rules/disagreeing-with-powerful-stakeholders/rule.md Line 88 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001

Please review and update your Markdown files accordingly.

@github-actions github-actions bot added Age: πŸ₯ - Adolescent About 8 hours old Age: 🐀 - Mature About 16 hours old and removed Age: 🐣 - Young About 4 hours old Age: πŸ₯ - Adolescent About 8 hours old labels Mar 22, 2024
@github-actions github-actions bot added Age: πŸ“ - Old About 32 hours old Age: πŸ— - Ancient About 64 hours old and removed Age: 🐀 - Mature About 16 hours old Age: πŸ“ - Old About 32 hours old labels Mar 22, 2024
Copy link
Contributor

Howzit @jaydenalchin,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added πŸ”₯ Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ Age: πŸ¦– - Extinct About 128 hours old and removed Age: πŸ— - Ancient About 64 hours old labels Mar 23, 2024
@jaydenalchin jaydenalchin merged commit dc59c01 into main Mar 25, 2024
4 of 5 checks passed
@jaydenalchin jaydenalchin deleted the jaydenalchin-patch-1 branch March 25, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: πŸ¦– - Extinct About 128 hours old πŸ”₯ Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants