Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Changes to rules to formatting new lines and inclusions in related rules #8272

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

joshbermanssw
Copy link
Contributor

Prompted from email 'Line breaks after a figure' from @adamcogan.

I have made changes to the rule 'Do you enhance readability with line breaks and spacing' (formally 'Do you know where to add new lines?' as per @tiagov8 request.

Copy link
Contributor

Hi @joshbermanssw,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/format-new-lines/rule.md Line 86 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: should be surrounded by blank lines Rule MD032

Please review and update your Markdown files accordingly.

Copy link
Contributor

github-actions bot commented Mar 27, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 94
Total 94

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Changes to rules to formatting new lines and inclusions in related rules XS✔ ◾ Changes to rules to formatting new lines and inclusions in related rules Mar 27, 2024
@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Mar 27, 2024
@tiagov8
Copy link
Member

tiagov8 commented Mar 27, 2024

cc @joshbermanssw

Hey @jaydenalchin

I've made so many changes to this rule that it deserves another pair of eyes...

  • 1. Please review this PR

rules/format-new-lines/rule.md Outdated Show resolved Hide resolved
rules/format-new-lines/rule.md Outdated Show resolved Hide resolved
Copy link
Member

@jaydenalchin jaydenalchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jaydenalchin jaydenalchin merged commit f00e32e into main Mar 27, 2024
5 checks passed
@jaydenalchin jaydenalchin deleted the changesToRulesToFormattingNewLines branch March 27, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🐤 - Mature About 16 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants