Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ Updated rule "dimensions-set-to-all" #8279

Merged
merged 4 commits into from
Mar 30, 2024
Merged

XS✔ ◾ Updated rule "dimensions-set-to-all" #8279

merged 4 commits into from
Mar 30, 2024

Conversation

tiagov8
Copy link
Member

@tiagov8 tiagov8 commented Mar 28, 2024 •
edited
Loading

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Re: SSW.Rules - Clarifying https://www.ssw.com.au/rules/reports-do-you-always-make-sure-the-dimensions-all-captions-all/

  1. What was changed?

Whole content by Uly

  1. Did you do pair or mob programming (list names)?

no

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Mar 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 63
Total 63

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Updated rule "dimensions-set-to-all" XS✔ ◾ Updated rule "dimensions-set-to-all" Mar 28, 2024
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Mar 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Howzit @tiagov8,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@adamcogan adamcogan merged commit 84a5ea5 into main Mar 30, 2024
@adamcogan adamcogan deleted the tiagov8-patch-9 branch March 30, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcogan adamcogan adamcogan approved these changes

@jeoffreyfischer jeoffreyfischer Awaiting requested review from jeoffreyfischer

@jaydenalchin jaydenalchin Awaiting requested review from jaydenalchin

Assignees
No one assigned
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiagov8 @adamcogan