Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Moving large .NET projects rules #8312

Merged
merged 7 commits into from
Apr 15, 2024
Merged

📝 Moving large .NET projects rules #8312

merged 7 commits into from
Apr 15, 2024

Conversation

fenix2222
Copy link
Contributor

@fenix2222 fenix2222 commented Apr 6, 2024 •
edited
Loading

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

SSW Rules migration

  1. What was changed?

Migrated Large .NET Projects Rule category

#8313

@fenix2222 fenix2222 requested a review from tiagov8 April 6, 2024 06:35
@fenix2222 fenix2222 changed the title 📝 Mmoving large net projects rules 📝 Moving large .NET projects rules Apr 6, 2024
@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Apr 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

Howzit @fenix2222,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@tiagov8
Copy link
Member

tiagov8 commented Apr 7, 2024

@igorgoldobin

FYI I am waiting for answer on other PRs before approve this

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Apr 9, 2024
JackDevAU
JackDevAU previously requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@JackDevAU JackDevAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@tiagov8
Copy link
Member

tiagov8 commented Apr 13, 2024

Hey @igorgoldobin

I think you need to update this after #8361

tiagov8
tiagov8 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@tiagov8 tiagov8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @igorgoldobin

  • 1. Please review all these rules live and make changes it needed.

I was not 100% about them, but approved anyways

@tiagov8 tiagov8 dismissed JackDevAU’s stale review April 15, 2024 17:17

assuming it's my comment, it was fixed by igor

@tiagov8 tiagov8 merged commit 69603f5 into SSWConsulting:main Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaydenalchin jaydenalchin jaydenalchin left review comments

@tiagov8 tiagov8 tiagov8 approved these changes

@JackDevAU JackDevAU JackDevAU left review comments

Assignees
No one assigned
Labels
Age: 🦖 - Extinct About 128 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fenix2222 @tiagov8 @JackDevAU @jaydenalchin @igorgoldobin