Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Update rule.md #8470

Merged
merged 1 commit into from
May 2, 2024
Merged

XS✔ ◾ Update rule.md #8470

merged 1 commit into from
May 2, 2024

Conversation

tomek-i
Copy link
Member

@tomek-i tomek-i commented Apr 30, 2024

Added additional paragraph to underline that the goal is not to sound transactional or like a sales pitch

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ The content felt a little bit like the goal is to be transactional

  1. What was changed?

✏️ added a small paragraph to clear things up

  1. Did you do pair or mob programming (list names)?

✏️ @cvionnet @steven0x51

Added additional paragraph to underline that the goal is not to sound transactional or like a sales pitch
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Apr 30, 2024
Copy link
Contributor

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 4
Total 4

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Update rule.md XS✔ ◾ Update rule.md Apr 30, 2024
Copy link
Contributor

Hi @tomek-i,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/weekly-client-love/rule.md Line 82: column count Rule MD056

Please review and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old labels Apr 30, 2024
@tomek-i tomek-i requested a review from adamcogan April 30, 2024 08:22
@github-actions github-actions bot added Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Apr 30, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

Howzit @tomek-i,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@adamcogan adamcogan merged commit 99ed0b3 into main May 2, 2024
6 of 7 checks passed
@adamcogan adamcogan deleted the tomek-i-patch-1 branch May 2, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants