Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rule: "Do you check your API serialisation format?" #8549

Merged
merged 4 commits into from
May 16, 2024

Conversation

christoment
Copy link
Contributor

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Things I found during migrating TimePro to .NET 8.

  1. What was changed?

Added rule - Do you check your API serialisation format?

  1. Did you do pair or mob programming (list names)?
    No

@christoment christoment changed the title Feat/net8 serialization Added rule: "Do you check your API serialisation format?" May 15, 2024
@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old labels May 15, 2024
@github-actions github-actions bot added Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels May 15, 2024
Copy link
Contributor

Howzit @christoment,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

Copy link
Contributor

@william-liebenberg william-liebenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jernejk jernejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The .NET Framework story is a bit less trivial because you have Katana, Owin, ASP.NET, ASP.NET Core and probably more. I remember some combination gave you camelCase by default.

I think, it's good as it is in order to not complicate it any further. 😄 (and that it slowly drifts into archive)

@christoment christoment merged commit 2a1e73d into SSWConsulting:main May 16, 2024
6 checks passed
@christoment christoment deleted the feat/net8-serialization branch May 16, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants