Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ Amending rule warn to call #8553

Merged
merged 2 commits into from
May 16, 2024
Merged

XS✔ ◾ Amending rule warn to call #8553

merged 2 commits into from
May 16, 2024

Conversation

Tanya-Leahy
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️Email from Adam: re: Calling - Do you warn then call? | SSW.Rules

  1. What was changed?

✏️added 'not hot calling' to the rule.

  1. Did you do pair or mob programming (list names)?

✏️No

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 2
Total 2

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Amending rule warn to call XS✔ ◾ Amending rule warn to call May 16, 2024
leahy268
leahy268 approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@leahy268 leahy268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leahy268 leahy268 merged commit 1d34e9f into main May 16, 2024
@leahy268 leahy268 deleted the add-no-hot-calling branch May 16, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahy268 leahy268 leahy268 approved these changes

Assignees
No one assigned
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tanya-Leahy @leahy268