Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major updates to rule about version control for Power BI #8598

Merged
merged 10 commits into from
May 26, 2024

Conversation

divgul
Copy link
Contributor

@divgul divgul commented May 24, 2024

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️Adam reviewed the original rule and gave feedback

  1. What was changed?

✏️Rule - https://www.ssw.com.au/rules/do-you-use-version-control-with-power-bi/

  • Re-wrote the introduction to show the drawbacks of directly publishing reports into Power BI Service
  • Showed benefits of converting reports to the PBIP format before committing them to version control
  • Re-structured the section that describes foundational concepts
  1. Did you do pair or mob programming (list names)?

✏️No, but did get good feedback from @adamcogan and @uly1

@divgul divgul requested review from adamcogan, tiagov8 and uly1 May 24, 2024 08:52
@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old labels May 24, 2024
@github-actions github-actions bot added Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels May 24, 2024
Copy link
Contributor

Howzit @divgul,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@divgul divgul merged commit fefd21c into SSWConsulting:main May 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants