Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ Multi tenancy solution #9485

Merged
merged 5 commits into from
Oct 27, 2024
Merged

XS✔ ◾ Multi tenancy solution #9485

merged 5 commits into from
Oct 27, 2024

Conversation

ricksu978
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

https://github.com/SSWConsulting/SSW.YakShaver/issues/924

  1. What was changed?
  • Added a new rule for multi tenancy solution
  1. Did you do pair or mob programming (list names)?

No

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 56
Total 56

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Multi tenancy solution XS✔ ◾ Multi tenancy solution Oct 25, 2024
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Oct 25, 2024
tiagov8
tiagov8 reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@tiagov8 tiagov8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricksu978

I commited some changes (have a look and let me know if in doubt), so will wait for someone else to approve

@tiagov8 tiagov8 requested a review from tomek-i October 25, 2024 22:05
@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Howzit @ricksu978,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Oct 27, 2024
@uly1 uly1 merged commit 4c540fe into main Oct 27, 2024
5 checks passed
@uly1 uly1 deleted the ricksu/multi-tenancy branch October 27, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagov8 tiagov8 tiagov8 left review comments

@uly1 uly1 uly1 approved these changes

@tomek-i tomek-i Awaiting requested review from tomek-i

Assignees
No one assigned
Labels
Age: 🦖 - Extinct About 128 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ricksu978 @tomek-i @tiagov8 @uly1