Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ Improving readability, cleaning up, and shortening URI #9501

Merged
merged 7 commits into from
Oct 30, 2024
Merged

XS✔ ◾ Improving readability, cleaning up, and shortening URI #9501

merged 7 commits into from
Oct 30, 2024

Conversation

sethdaily
Copy link
Member

@sethdaily sethdaily commented Oct 29, 2024 •
edited
Loading

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ myself - reviewing the rule before using it for CTF
Following: https://www.ssw.com.au/rules/concise-writing/

  1. What was changed?

✏️

  1. Did you do pair or mob programming (list names)?

✏️

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 158
Total 158

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Improving readability, cleaning up, and shortening URI XS✔ ◾ Improving readability, cleaning up, and shortening URI Oct 29, 2024
tiagov8
tiagov8 requested changes Oct 29, 2024
View reviewed changes
rules/rest-api-design/rule.md Show resolved Hide resolved
rules/rest-api-design/rule.md Outdated Show resolved Hide resolved
danielmackay
danielmackay approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@danielmackay danielmackay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethdaily sethdaily enabled auto-merge (squash) October 30, 2024 01:16
jeoffreyfischer
jeoffreyfischer approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jeoffreyfischer jeoffreyfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old and removed Age: 🥚 - New About 2 hours old labels Oct 30, 2024
tiagov8
tiagov8 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@tiagov8 tiagov8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sethdaily

FYI - I fixed the redirect thing alrady so this can be merged

@sethdaily sethdaily merged commit 2ae4593 into main Oct 30, 2024
5 checks passed
@sethdaily sethdaily deleted the sethdaily-patch-19 branch October 30, 2024 03:58
@github-actions github-actions bot restored the sethdaily-patch-19 branch October 30, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeoffreyfischer jeoffreyfischer jeoffreyfischer approved these changes

@tiagov8 tiagov8 tiagov8 approved these changes

@danielmackay danielmackay danielmackay approved these changes

Assignees
No one assigned
Labels
Age: 🐣 - Young About 4 hours old
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sethdaily @danielmackay @tiagov8 @jeoffreyfischer