-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XS✔ ◾ improving heading sizes #9507
Conversation
PR Metrics✔ Thanks for keeping your pull request small.
Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs! |
Hi @sethdaily, We found some markdown suggestions for your Pull Request:
Please review and update your Markdown files accordingly. |
❌ Not Done - as Tiago told me in the past, we should only have a single h1 per page to improve SEO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sethdaily
As per @jeoffreyfischer
We should not use H1 in content: https://www.ssw.com.au/rules/rules-to-better-technical-documentation/#1-headings-paragraphs-and-blockquotes
We should also aim to follow the hierarchy... so an h4
only comes after/under a h3
, etc
I've made several small changes to your PR... to reflect the above + for consistency and readability
I will leave it for someone else to approve because of my own changes.
Howzit @sethdaily, This PR has been here a while. Did you know you should avoid merge debt?
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✏️ i want to see if it looks better
✏️
✏️