Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ improving heading sizes #9507

Merged
merged 3 commits into from
Oct 31, 2024
Merged

XS✔ ◾ improving heading sizes #9507

merged 3 commits into from
Oct 31, 2024

Conversation

sethdaily
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ i want to see if it looks better

  1. What was changed?

✏️

  1. Did you do pair or mob programming (list names)?

✏️

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 42
Total 42

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title improving heading sizes XS✔ ◾ improving heading sizes Oct 30, 2024
Copy link
Contributor

Hi @sethdaily,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/rest-api-design/rule.md Line 32 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: top-level headings in the same document Rule MD025
rules/rest-api-design/rule.md Line 36 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001
rules/rest-api-design/rule.md Line 127 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: top-level headings in the same document Rule MD025
rules/rest-api-design/rule.md Line 131 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001

Please review and update your Markdown files accordingly.

@jeoffreyfischer
Copy link
Member

jeoffreyfischer commented Oct 30, 2024

❌ Not Done - as Tiago told me in the past, we should only have a single h1 per page to improve SEO.
For rules, the h1 is used for the title.
So the largest heading size you can use for rule sections is an h2

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Oct 30, 2024
Copy link
Member

@tiagov8 tiagov8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sethdaily

As per @jeoffreyfischer
We should not use H1 in content: https://www.ssw.com.au/rules/rules-to-better-technical-documentation/#1-headings-paragraphs-and-blockquotes

We should also aim to follow the hierarchy... so an h4 only comes after/under a h3, etc

I've made several small changes to your PR... to reflect the above + for consistency and readability

I will leave it for someone else to approve because of my own changes.

@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old and removed Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Oct 30, 2024
Copy link
Contributor

Howzit @sethdaily,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added the 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ label Oct 31, 2024
Copy link
Member

@jeoffreyfischer jeoffreyfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeoffreyfischer jeoffreyfischer merged commit fd9cfef into main Oct 31, 2024
@jeoffreyfischer jeoffreyfischer deleted the sethdaily-patch-20 branch October 31, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants