Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ Small improvements to the rule /close-off-thread/ #9511

Merged
merged 2 commits into from
Nov 1, 2024
Merged

XS✔ ◾ Small improvements to the rule /close-off-thread/ #9511

merged 2 commits into from
Nov 1, 2024

Conversation

tiagov8
Copy link
Member

@tiagov8 tiagov8 commented Oct 30, 2024 •
edited
Loading

cc @PothieuG

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

@adamcogan 's email: ✅ Done - xxx

  1. What was changed?

Added emoji + PBI mention + small improvements to readability

  1. Did you do pair or mob programming (list names)?

no

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 8
Total 8

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Small improvements to the rule /close-off-thread/ XS✔ ◾ Small improvements to the rule /close-off-thread/ Oct 30, 2024
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Oct 30, 2024
@PothieuG
Copy link
Member

@tiagov8

1.What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

It was a Messenger conversation with NDC clients.
They asked us to deploy in production fixes and I didn't reply as per this rule.

Thanks for the change !

@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old and removed Age: 🐤 - Mature About 16 hours old labels Oct 31, 2024
@github-actions github-actions bot added Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐓 - Old About 32 hours old labels Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Howzit @tiagov8,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@tiagov8 tiagov8 requested a review from PothieuG November 1, 2024 20:22
@tiagov8 tiagov8 enabled auto-merge (squash) November 1, 2024 20:23
adamcogan
adamcogan approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@adamcogan adamcogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adam with Jeff and Tiago

@tiagov8 tiagov8 merged commit a5df655 into main Nov 1, 2024
@tiagov8 tiagov8 deleted the tiagov8-patch-19 branch November 1, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcogan adamcogan adamcogan approved these changes

@bradystroud bradystroud Awaiting requested review from bradystroud

@amankumarrr amankumarrr Awaiting requested review from amankumarrr

@BrookJeynes BrookJeynes Awaiting requested review from BrookJeynes

@PothieuG PothieuG Awaiting requested review from PothieuG

Assignees
No one assigned
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiagov8 @PothieuG @adamcogan