Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Added warning to not try other effects in text hover #9755

Merged
merged 9 commits into from
Jan 14, 2025

Conversation

tiagov8
Copy link
Member

@tiagov8 tiagov8 commented Jan 9, 2025

cc @bettybondoc @kikibianc @isaaclombardssw @JeanThirion @Aibono1225 @tomek-i @tino-liu @calumjs @RobJT-wq

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

@adamcogan 's on Re: Rollover links not underlined | SugarLearning

  1. What was changed?

Added warning box + other improvements

@tiagov8 tiagov8 requested a review from jaydenalchin January 9, 2025 13:16
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 34
Total 34

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Added warning to not try other effects in text hover XS✔ ◾ Added warning to not try other effects in text hover Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Hi @tiagov8,

Rule: ../../rules/underlined-links/rule.md

Issues Detected:

  • must have required property 'seoDescription'

Please fix the Frontmatter in your Markdown files.

@tiagov8 tiagov8 requested a review from hveraus January 9, 2025 13:20
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Hi @tiagov8,

Rule: ../../rules/underlined-links/rule.md

Issues Detected:

  • must have required property 'seoDescription'

Please fix the Frontmatter in your Markdown files.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Hi @tiagov8,

Rule: ../../rules/underlined-links/rule.md

Issues Detected:

  • must have required property 'seoDescription'

Please fix the Frontmatter in your Markdown files.

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Hi @tiagov8,

Rule: ../../rules/underlined-links/rule.md

Issues Detected:

  • must have required property 'seoDescription'

Please fix the Frontmatter in your Markdown files.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Hi @tiagov8,

Rule: ../../rules/underlined-links/rule.md

Issues Detected:

  • must have required property 'seoDescription'

Please fix the Frontmatter in your Markdown files.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old labels Jan 9, 2025
@tiagov8 tiagov8 requested a review from bettybondoc January 10, 2025 14:16
@github-actions github-actions bot added Age: 🍗 - Ancient About 64 hours old and removed Age: 🐓 - Old About 32 hours old labels Jan 10, 2025
@github-actions github-actions bot added the 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ label Jan 11, 2025
Copy link
Contributor

Howzit @tiagov8,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Jan 12, 2025
Copy link
Member

@bettybondoc bettybondoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagov8 tiagov8 merged commit fc41f8c into main Jan 14, 2025
5 checks passed
@tiagov8 tiagov8 deleted the tiagov8-patch-22 branch January 14, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🦖 - Extinct About 128 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants