Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ ♻️ Remove Invalid Component Libraries from List #9758

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

MattParkerDev
Copy link
Member

@MattParkerDev MattParkerDev commented Jan 9, 2025

cc @adamcogan

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Rule is wrong

  1. What was changed?

Removed Tailwind and SignalR

  1. Did you do pair or mob programming (list names)?

No

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code -
Total -

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title ♻️ Remove Invalid Component Libraries from List XS✔ ◾ ♻️ Remove Invalid Component Libraries from List Jan 9, 2025
Copy link
Member

@isaaclombardssw isaaclombardssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a case could be made for tailwind (often used in place of a library) but otherwise LGTM – thanks!

@MattParkerDev
Copy link
Member Author

I think a case could be made for tailwind (often used in place of a library) but otherwise LGTM – thanks!

@isaaclombardssw Its not a component library though - you don't get any components. Its a css styling library basically.

@isaaclombardssw
Copy link
Member

I think a case could be made for tailwind (often used in place of a library) but otherwise LGTM – thanks!

@isaaclombardssw Its not a component library though - you don't get any components. Its a css styling library basically.

Yep, true. So I'm fine with removing it from that list. 👍

@MattParkerDev MattParkerDev merged commit a898c4e into main Jan 9, 2025
7 checks passed
@MattParkerDev MattParkerDev deleted the fix-rule branch January 9, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants