Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ Removed latest rules widget functions and entity context for Cosmos DB #83

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Sep 25, 2024

Relates: SSWConsulting/SSW.Rules#1438

As we have made changes to Latest Rules widget to use history.json and commits.json as it's data source, we are no longer need the functions and entity context used by widget previously.

Changes:

  1. Deleted GetLatestRules and UpdateLatestRules functions
  2. Deleted the LatestRules entity from RulesDbContext
  3. Deleted docs/Functions/Functions.http located in root folder as it is duplicate with docs/Functions/Functions.http inside SSW.Rules.AzFuncs project

image
Figure: UpdateLatestRules was called last time 19th September

image
Figure: GetLatestRules was called last time 21st September

@babakamyljanovssw
Copy link
Member Author

cc: @JackDevAU @bradystroud

I will be checking invocation list of these functions on Friday, and if there are no any new calls, then I proceed with merge.

@babakamyljanovssw
Copy link
Member Author

@bradystroud @tkapa @JackDevAU

Update

The UpdateLatestRules functions wasn't being used after last time I checked which is good and can be removed safely, but the GetLatestRules function was called a few times.

image
Figure: A few calls made to function after last check

Not sure where it is being called from, this function was being used in widget, but we have updated widget to new version to use history.json.

I checked the request logs for this function before widget upgrade and after widget upgrade for the 7 day period:

  • 1400 logs are returned before widget upgrade
  • 7 logs are returned after widget upgrade

Currently investigating where these calls are made from

@babakamyljanovssw
Copy link
Member Author

babakamyljanovssw commented Oct 9, 2024

Hi @bradystroud,

While investigating Azure Functions I checked GetLatestRules and UpdateLatestRules functions usage, both of them weren't used for the last 7 days. If there is nothing else I will proceed with merging this PR.

image
Figure: Application Insights logs returned empty resulted for these functions

Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our conversation, this is not used any more

@babakamyljanovssw babakamyljanovssw merged commit 3d53736 into main Oct 10, 2024
3 checks passed
@babakamyljanovssw babakamyljanovssw deleted the remove-latest-rules-functions branch October 10, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants