Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Added comments headers #1602

Merged
merged 3 commits into from
Oct 29, 2024
Merged

♻️ Added comments headers #1602

merged 3 commits into from
Oct 29, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Oct 29, 2024 •
edited
Loading

Relates to #1567

Added header to Giscus and Disqus comment box, so both comment system can easily be distinguished and people can copy their old comments to new commenting system which is Giscus

image
Figure: Giscus and Disqus have header

@babakamyljanovssw babakamyljanovssw self-assigned this Oct 29, 2024
@SSWRules SSWRules changed the title added comments header added comments headers Oct 29, 2024
bradystroud
bradystroud requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some stuff to the PR description explaining why we have two comment systems at the moment?
The reason is, we want people to be able to easily copy their old comments into the new comment system

src/components/comments/comments.js Outdated Show resolved Hide resolved
src/components/discussion/discussion.js Outdated Show resolved Hide resolved
@babakamyljanovssw babakamyljanovssw changed the title added comments headers .♻️ Added comments headers Oct 29, 2024
@babakamyljanovssw babakamyljanovssw changed the title .♻️ Added comments headers ♻️ Added comments headers Oct 29, 2024
@babakamyljanovssw babakamyljanovssw merged commit fd55ca7 into main Oct 29, 2024
5 checks passed
@babakamyljanovssw babakamyljanovssw deleted the add-comments-header branch October 29, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradystroud bradystroud bradystroud approved these changes

Assignees

@babakamyljanovssw babakamyljanovssw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babakamyljanovssw @bradystroud