Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new env variable to separate staging and production discussions #1608

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Nov 1, 2024

Relates to #1567

As per feedback from Matt W, current implementation stores staging and production discussions in same place which leads to staging rules URL added to the discussion body.

I think the best way to avoid this issue or any staging and production crossing issues is we can store staging discussions in separate repo.

New behavior:

image
Figure: Staging URL was added to discussion that this discussion points to production rule as well

@babakamyljanovssw babakamyljanovssw merged commit 8c82d3b into main Nov 4, 2024
6 checks passed
@babakamyljanovssw babakamyljanovssw deleted the refactor-giscus branch November 4, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants