Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Custom training options #1260

Closed
wants to merge 23 commits into from
Closed

✨Custom training options #1260

wants to merge 23 commits into from

Conversation

KristenHu
Copy link
Contributor

@KristenHu KristenHu commented Aug 17, 2023 •
edited
Loading

Fixes #601 - Migrate events page: Custom Training Options

Affected routes:

-events/customized-courses

Add done video, screenshots

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 95
Performance 28.000000000000004
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@KristenHu KristenHu changed the title Custom training options ✨Custom training options Aug 18, 2023
bradystroud
bradystroud requested changes Aug 19, 2023
View reviewed changes
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image These testimonials should use the testimonials component

FYI the url in your description gives a 404, it should be events/customized-courses

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 95
Performance 28.000000000000004
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 95
Performance 28.999999999999996
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@KristenHu KristenHu marked this pull request as ready for review August 28, 2023 06:57
@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 95
Performance 34
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 95
Performance 32
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@bradystroud
Copy link
Member

bradystroud commented Sep 4, 2023 •
edited
Loading

Hey @KristenHu
Is this one ready for review?
Seems like my requested changes haven't been fixed yet

Please make this a draft PR if its not ready for review

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Deployed changes to https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

PageSpeed Insights

Category Score
Accessibility 91
Best practices 95
Performance 32
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@KristenHu
Copy link
Contributor Author

KristenHu commented Sep 5, 2023 •
edited
Loading

Hey @KristenHu Is this one ready for review? Seems like my requested changes haven't been fixed yet

Please make this a draft PR if its not ready for review

Hey @bradystroud ,
Yes, It's ready for review now. Ken and I just got test pass for the banner of the page this morning, I've pushed it to the PR.

As per our conversation in Teams, we won't use testimonials component here currently, so there's nothing needs to be fixed😊
image

bradystroud
bradystroud requested changes Sep 6, 2023
View reviewed changes
public/images/background/SSWTraining.png Outdated Show resolved Hide resolved
content/events/customized-courses.mdx Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Deployed changes to https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Deployed changes to https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

PageSpeed Insights

Category Score
Accessibility 91
Best practices 95
Performance 27
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Deployed changes to https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

PageSpeed Insights

Category Score
Accessibility 91
Best practices 95
Performance 26
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1260.azurewebsites.net

Merge branch 'CustomTrainingOptions' of https://github.com/SSWConsult…
1d26208 
…ing/SSW.Website-v3 into CustomTrainingOptions

# Conflicts:
#	.tina/__generated__/client.ts
#	.tina/__generated__/config.prebuild.jsx
@KristenHu
Copy link
Contributor Author

KristenHu commented Sep 7, 2023 •
edited
Loading

As per my conversation with @bradystroud , this PR will be closed since there are too much unknown changes in .tina folder, and the new PR has been created: #1361

@KristenHu KristenHu closed this Sep 7, 2023
@amankumarrr amankumarrr deleted the CustomTrainingOptions branch September 21, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradystroud bradystroud bradystroud requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📄 Events - Custom Training Options
2 participants
@KristenHu @bradystroud