Skip to content

What to make sure before merging a PR? [Strictly for future Admins!]

Shreyas Bapat edited this page Oct 10, 2018 · 2 revisions
  • It must not have any merge conflicts
  • The branch to be pulled must be in coordination with base master
  • If not, ask them to rebase!
  • Best way to rebase is(lengthy but hasslefree):
# Checkout from working branch to local master
git checkout master
git remote add upstream https://github.com/STAC-IITMandi/STAC-IITMandi.github.io.git
git fetch upstream
git rebase upstream/master
# Checkout to working branch
git checkout Branch_Name
git rebase master
  • Do Not behave rudely to anyone.
  • Give fair reviews.
  • Don't ask anyone to write very proper commit messages because afterall, it's a website!
Clone this wiki locally