Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide refresh token support #363

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Provide refresh token support #363

merged 4 commits into from
Mar 5, 2025

Conversation

antoineatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Provides support of refresh-token, with Automatic service implemented and already fully tested inside the WebApp

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
45.9% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@antoineatstariongroup antoineatstariongroup merged commit 999cf4c into development Mar 5, 2025
8 of 9 checks passed
@antoineatstariongroup antoineatstariongroup deleted the feat/support-refresh-token branch March 5, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samatstariongroup samatstariongroup samatstariongroup approved these changes

@lxatstariongroup lxatstariongroup lxatstariongroup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoineatstariongroup @samatstariongroup @lxatstariongroup