Provides support for token refresh #381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoineatstariongroup
requested review from
samatstariongroup and
lxatstariongroup
samatstariongroup
requested changes
Feb 27, 2025
| if (!appConfigService.IsAuthenticationSchemeEnabled(JwtBearerDefaults.LocalAuthenticationScheme)) | ||
| { | ||
| context.Response.StatusCode = (int)HttpStatusCode.Forbidden; | ||
| await context.Response.WriteAsync("Local JWT Authentication is disable."); |
CometServer/Startup.cs
Outdated
|
|
||
| if (refreshExpirationMinutes <= 0) | ||
| { | ||
| throw new ConfigurationErrorsException("The Authentication:LocalJwtBearer:RefreshExpirationMinutes setting must be strickly greater than 0"); |
| @@ -60,8 +60,9 @@ | |||
| "IsEnabled": false, | |||
| "ValidIssuer": "CDP4-COMET", | |||
| "ValidAudience": "localhost:5000", | |||
| "SymmetricSecurityKey": "needs-to-be-updated-with-a-secret", | |||
| "TokenExpirationMinutes": 150 | |||
| "SymmetricSecurityKey": "needs-to-be-updated-with-a-secret", | |||
There was a problem hiding this comment.
please make sure to update the wiki with this information
There was a problem hiding this comment.
Configuration page updated, gonna update ICD
|
|
||
| /// <summary> | ||
| /// The purpose of the <see cref="JwtTokenService"/> is to generate a JWT token based on the provided authenticated | ||
| /// The purpose of the <see cref="JwtTokenService" /> is to generate a JWT token based on the provided authenticated |
lxatstariongroup
approved these changes
Feb 27, 2025
samatstariongroup
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description