Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing V1.9.1 release #6254

Merged
merged 72 commits into from
Jul 10, 2023
Merged

Preparing V1.9.1 release #6254

merged 72 commits into from
Jul 10, 2023

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented May 22, 2023 •
edited
Loading

Fixes #6244

@hkaiser hkaiser added this to the 1.9.1 milestone May 22, 2023
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2023-03-06T15:59:25+00:002023-05-25T22:01:36+00:00
HPX Commit6b6e1e7c2ec582
Envfile
Clusternamerostamrostam
Datetime2023-03-10T03:27:49.135034-06:002023-05-25T18:27:01.720804-05:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Datetime2023-03-06T15:59:25+00:002023-05-25T22:01:36+00:00
HPX Commit6b6e1e7c2ec582
Envfile
Clusternamerostamrostam
Datetime2023-03-10T03:28:21.991297-06:002023-05-25T18:27:34.902519-05:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)-(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)-(=)

Info

PropertyBeforeAfter
HPX Datetime2023-03-06T15:59:25+00:002023-05-25T22:01:36+00:00
HPX Commit6b6e1e7c2ec582
Envfile
Clusternamerostamrostam
Datetime2023-03-10T03:28:29.145749-06:002023-05-25T18:27:42.158352-05:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)+(=)

Info

PropertyBeforeAfter
HPX Commit6b6e1e70939f80
HPX Datetime2023-03-06T15:59:25+00:002023-05-26T13:10:34+00:00
Datetime2023-03-10T03:27:49.135034-06:002023-05-26T08:37:08.105475-05:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Commit6b6e1e70939f80
HPX Datetime2023-03-06T15:59:25+00:002023-05-26T13:10:34+00:00
Datetime2023-03-10T03:28:21.991297-06:002023-05-26T08:37:40.234223-05:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add=(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad=(=)(=)
Stream Benchmark - Copy(=)-(=)

Info

PropertyBeforeAfter
HPX Commit6b6e1e70939f80
HPX Datetime2023-03-06T15:59:25+00:002023-05-26T13:10:34+00:00
Datetime2023-03-10T03:28:29.145749-06:002023-05-26T08:37:47.510664-05:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

hkaiser and others added 17 commits June 14, 2023 09:52
@hkaiser
Resolve gcc problems on Windows
49b3142 
- flyby: resolve winsock2.h warnings on windows
- flyby: add CI builder for gcc/mingw on Windows

# Conflicts:
#	libs/core/config/include/hpx/config/asio.hpp
#	libs/core/resource_partitioner/examples/guided_pool_test.cpp
#	libs/core/thread_support/include/hpx/thread_support/set_thread_name.hpp
#	libs/core/thread_support/src/set_thread_name.cpp
@hkaiser
Remove duplicate headers, instead generate those on demand
38fd73f
@hkaiser
Cleaning up #includes in hpx/ folder
ed78082 
- unifying `<hpx/local/...>` and `<hpx/...>`
@G-071 @hkaiser
Re-enable tests
ccb88f4 
Tests were disabled in #5796
@G-071 @hkaiser
Fix compute architecture and drop kepler
1e1becb 
Kepler support is removed in CUDA 12 so it's time to remove it here as
well.
@G-071 @hkaiser
Revert "Re-enable tests"
7d46238 
This reverts commit 9d5a4a8.
Still not working unfortunately (tested with gcc/12 and cuda 12.1)
@G-071 @hkaiser
Disable troublesome tests for current cuda version
721a7a1
@G-071 @hkaiser
Allow jenkins hip builds with warnings
074e11f
@G-071 @hkaiser
Remove broken node for testing
3dad652
@G-071 @hkaiser
Temporarily switch to rocm/4
2c46a0d 
As all rocm/5 modules are currently broken on the machine
@G-071 @hkaiser
Revert "Temporarily switch to rocm/4"
203188c 
This reverts commit 71c8ac3.
@G-071 @hkaiser
Increase test timeout
e088782
@G-071 @hkaiser
Revert "Increase test timeout"
a49248c 
This reverts commit 087074a.
@G-071 @hkaiser
Test excluding troublesome hip alorithms test
19dccf0
@SAtacker @hkaiser
Cmake Tests: Delete operator check for size_t arg
3501af7 
- Clang fails to recognize the global delete operator which has 2 arguments the second one being std::size_t

Signed-off-by: Shreyas Atre <[email protected]>
@SAtacker @hkaiser
Add maybe_unused attribute
7b1fe66 
Co-authored-by: Hartmut Kaiser <[email protected]>
@SAtacker @hkaiser
Fix inspect issues: Add newline to the added test
2752a07 
Signed-off-by: Shreyas Atre <[email protected]>
G-071 and others added 27 commits July 10, 2023 09:22
@G-071 @hkaiser
Initial hardcoded version
4e03b0a
@G-071 @hkaiser
Detect number of GPUs
6e5e270
@G-071 @hkaiser
Cleanup
ef12f35
@G-071 @hkaiser
Add missing default value
8b8c6c0
@G-071 @hkaiser
Fix format
4d698c9
@G-071 @hkaiser
Add missing format fix
db64b6a
@G-071 @hkaiser
Add default device arguments
20e8492
@G-071 @hkaiser
Fix asserts
3e46951
@G-071 @hkaiser
Delete copy/move event pool constructors
323ae69
@G-071 @hkaiser
Fix unused parameter warning
8d46517
@G-071 @hkaiser
Switch to east const
017109a
@G-071 @hkaiser
Add -1 default parameter for device auto-detection
3e26df2
@G-071 @hkaiser
Fix assert
c572755
@G-071 @hkaiser
Restore original device after init
eebcdca
@G-071 @hkaiser
Remove superfluous cudaSetDevice
e1a3ef9
@G-071 @hkaiser
Put event pool singleton access definition in src
aba2b0e
@G-071 @hkaiser
Add basic multi gpu polling test
c2d81c3
@G-071 @hkaiser
Fix assert (again)
b62a3fe
@G-071 @hkaiser
Add test for default device ID
7e82358
@G-071 @hkaiser
Fix some format issues / update file author lists
7da1dd0
@G-071 @hkaiser
Fix test format
beb233e
@G-071 @hkaiser
Cal setdevice when creating events on-demand
3b8cd90
@G-071 @hkaiser
Fix format (again)
afe52e7
@G-071 @hkaiser
Remove superfluous api call
1d59503
@G-071 @hkaiser
Fix inspect
a2c6bc3
@JiakunYan @hkaiser
update(lci pp): update the default version of LCI autofetch to v1.7.5
793e5a6
@JiakunYan @hkaiser
Update the documentation for the LCI parcelport.
bf05f03
@hkaiser hkaiser merged commit ca2b966 into release-1.9.X Jul 10, 2023
16 of 17 checks passed
@hkaiser hkaiser deleted the release-1.9.1 branch July 10, 2023 16:42
@hkaiser hkaiser mentioned this pull request Jul 10, 2023
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg Awaiting requested review from msimberg msimberg is a code owner

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees
No one assigned
Labels
type: compatibility issue
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.
7 participants
@hkaiser @StellarBot @dimitraka @G-071 @SAtacker @akheir @JiakunYan