Refactor how GA shared ID is added to the pages #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pookmish
force-pushed
the
refactor-shared-analytics
branch
2 times, most recently
from
48386ca to
0165a30
Compare
pookmish
force-pushed
the
refactor-shared-analytics
branch
from
0165a30 to
dd56420
Compare
sherakama
reviewed
Apr 9, 2024
Comment on lines
+121
to
+123
| // Only add Google Analytics for anonymous users or users without editing | ||
| // access while on Acquia environment. Being able to view the toolbar is a | ||
| // good indicator that they can edit some part of the site. |
There was a problem hiding this comment.
@pookmish thanks for these changes.
@buttonwillowsix, does this logic match how we are using our GA tracking code?
Would this opt-out most users on the intranet sites?
There was a problem hiding this comment.
Clearly I need to change my github notification settings.
It would need to track authenticated users on intranets. I wonder if we should revisit this later since we may be changing the method used for adding GA to the site.
|
gentle poke. no rush |
Code works and makes sense to me. Just looking to @buttonwillowsix to confirm intent or business case alignment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Setup tasks and/or behavior to test
$config['google_analytics.settings']['account'] = '';in thegoogle_analytics.settings.phpfile/admin/config/system/basic-site-settings