Web UI #15
Merged
Web UI #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mdemare
commented
Oct 12, 2024
mdemare
commented
- View status
- Removed wrap-routes
- Last fixes
joodie
requested changes
Oct 23, 2024
| {:body (if client-id "Unknown client id" "No client-id found") | ||
| :status http-status/forbidden}))) | ||
| (fn allowed-clients-checker [request] | ||
| (let [{:keys [client-id public] :as resp} (app request)] |
There was a problem hiding this comment.
Client ID moet op request zitten anders mag je (app request) niet doen! Nu gooi je gewoon response weg als achteraf blijkt dat dit niet mocht.....
Zet hier ook even een comment bij als je dit fixt want dit is de 2e keer dat het hier fout gaat.
There was a problem hiding this comment.
wrap-authentication wordt als eerste uitgevoerd, dus er is nog niks gebeurd, behalve de routing. Ik heb de middleware expres zo geschreven dat ze als eerste (app request) uitvoeren, om het geheel wat minder onoverzichtelijk te maken.
mdemare
force-pushed
the
webview
branch
2 times, most recently
from
7283e58 to
d33816c
Compare
joodie
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.