Redis config fixes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer use a default value, since this makes it harder to spot if the configuration is actually broken.
joodie
force-pushed
the
redis-config-fixes
branch
from
fe9a088 to
2405c87
Compare
- Pass redis connection info to goose client (producer) and worker (consumer) - Ensure that worker is shut down correctly
joodie
force-pushed
the
redis-config-fixes
branch
from
c21b84a to
fc75410
Compare
remvee
requested changes
Jan 22, 2025
| :body (json/write-str (assoc-in {} [:gateway :endpoints :google.com :responseCode] 200))})] | ||
| (response-match {:status 200 :body {:valid true}} | ||
| {:uri "/endpoints/google.com/config" :request-method :post}))) | ||
| (is (= {:status 200 :body {:valid true}} |
| {:uri "/endpoints/google.com/config" :request-method :post}))) | ||
| (is (= {:status 200 :body {:valid true}} | ||
| (result "google.com" | ||
| {:status 200 |
| (response-match {:status 200 | ||
| :body {:valid false :message "Endpoint validation failed with status: 500"}} | ||
| {:uri "/endpoints/google.com/config" :request-method :post}))) | ||
| (is (= {:status 200 |
| (with-redefs [http/request (fn [_] {:status 500 :body {:message "mocked response"}})] | ||
| (response-match {:status 500 :body {}} | ||
| {:uri "/endpoints/google.com/config" :request-method :post}))) | ||
| (is (= {:status 500 :body {}} |
| @@ -35,4 +35,4 @@ | |||
| (catch Throwable e | |||
| (log/error e "Internal error in validator-service") | |||
| {:status http-status/internal-server-error | |||
| :body {}}))) | |||
| :body {:error (ex-message e)}}))) | |||
There was a problem hiding this comment.
Ik weet niet of dit een goed idee is. Gaat buitenstaanders niets aan wat er precies mis ging.
| @@ -98,9 +99,34 @@ | |||
| (wrap-json-response) | |||
| (wrap-defaults api-defaults)))) | |||
|
|
|||
| (defn error-message-from-response | |||
| [{:keys [status body]}] | |||
| (if (<= 400 status) | |||
There was a problem hiding this comment.
(when (or (http-status-codes/client-error-status? status)
(http-status-codes/server-error-status? status))
| [handler] | ||
| (fn [request] | ||
| (try (let [{:keys [status body] :as response} (handler request)] | ||
| (if (<= 500 status) |
There was a problem hiding this comment.
(http-status-codes/server-error-status? status)| @@ -101,7 +101,7 @@ | |||
|
|
|||
| (defn error-message-from-response | |||
| [{:keys [status body]}] | |||
| (if (<= 400 status) | |||
| (when (<= 400 status) | |||
There was a problem hiding this comment.
(when (or (http-status-codes/client-error-status? status)
(http-status-codes/server-error-status? status))
| @@ -0,0 +1,37 @@ | |||
| (ns taoensso.encore | |||
There was a problem hiding this comment.
Ik begrijp niet wat dit is en waarvoor het is.
joodie
force-pushed
the
redis-config-fixes
branch
8 times, most recently
from
0d900e8 to
c7b54f6
Compare
mdemare
reviewed
Jan 28, 2025
| @@ -23,6 +24,7 @@ | |||
| (is (= http-status/ok status)) | |||
| body)) | |||
|
|
|||
| ;; TODO: Explain what this does and why | |||
There was a problem hiding this comment.
This is a thread-safe mock implementation of a job queue. It will atomically return the top item on the queue and remove that item from the queue.
mdemare
approved these changes
Jan 28, 2025
joodie
force-pushed
the
redis-config-fixes
branch
from
c7cea4d to
5b8b782
Compare
- Adds start! and stop! functions for whole system - Set application log level to DEBUG when REPL is started - Fix jetty lifecycle handling when app is restarted in repl
joodie
force-pushed
the
redis-config-fixes
branch
from
5b8b782 to
85e0c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.