Improve component Type of service UX

- JS validation was added. This improves the rules regarding selecting the number of required TOS entries - The addition of the ;decorated; class on the choice attributes improved styling - html5 validation was added, the group is now `required`
SURFnet · Jul 3, 2024 · 7de2cf9 · 7de2cf9
1 parent 28ee05d
commit 7de2cf9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/.../ServiceProviderDashboard/Infrastructure/DashboardBundle/Form/Entity/OidcngEntityType.php b/.../ServiceProviderDashboard/Infrastructure/DashboardBundle/Form/Entity/OidcngEntityType.php
@@ -249,10 +249,15 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                 'typeOfService',
                 ChoiceType::class,
                 [
-                    'required' => false,
+                    'required' => true,
                     'choices' => $this->typeOfServiceProvider->getTypesOfServiceChoices(),
                     'choice_value' => fn(TypeOfService $tos): string => $tos->typeEn,
                     'choice_label' => fn(TypeOfService $tos): string => $tos->typeEn,
+                    'choice_attr' => fn(): array => [
+                        'class' => 'decorated',
+                        'data-parsley-mincheck' => 1,
+                        'data-parsley-maxcheck' => 3,
+                    ],
                     'expanded' => true,
                     'multiple' => true,
                     'attr' => [

diff --git a/...et/ServiceProviderDashboard/Infrastructure/DashboardBundle/Form/Entity/SamlEntityType.php b/...et/ServiceProviderDashboard/Infrastructure/DashboardBundle/Form/Entity/SamlEntityType.php
@@ -241,10 +241,15 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                         'typeOfService',
                         ChoiceType::class,
                         [
-                            'required' => false,
+                            'required' => true,
                             'choices' => $this->typeOfServiceProvider->getTypesOfServiceChoices(),
                             'choice_value' => fn(TypeOfService $tos): string => $tos->typeEn,
                             'choice_label' => fn(TypeOfService $tos): string => $tos->typeEn,
+                            'choice_attr' => fn(): array => [
+                                'class' => 'decorated',
+                                'data-parsley-mincheck' => 1,
+                                'data-parsley-maxcheck' => 3,
+                            ],
                             'expanded' => true,
                             'multiple' => true,
                             'attr' => [