Skip to content

Commit

Permalink
Allow toggling of Jira failure simulation
Browse files Browse the repository at this point in the history
And adjust other webtests to the new Fixtures created for the surfconext
representative page
  • Loading branch information
MKodde committed Jun 18, 2024
1 parent 9d22f85 commit 89bee6d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ public function shouldFailCreateIssue(): void
$this->failIssueCreation = true;
$this->storeData();
}
public function shouldNotFailCreateIssue(): void
{
$this->loadData();
$this->failIssueCreation = false;
$this->storeData();
}

public function findByManageIds(array $manageIds): IssueCollection
{
Expand Down
1 change: 1 addition & 0 deletions tests/webtests/EntityDetailTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public function test_render_details_of_removal_requested_manage_entity()
);

$issueType = 'spd-delete-production-entity';
$this->jiraIssueRepository->shouldNotFailCreateIssue();
$this->createjiraTicket($entityId, $issueType);

$this->switchToService('SURFnet');
Expand Down
2 changes: 1 addition & 1 deletion tests/webtests/ServiceCreateTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@ public function test_empty_institution_id_field_is_allowed()
self::fillFormField($form, 'input[name="dashboard_bundle_service_type[teams][teamManagerEmail]"]', '[email protected]');
self::findBy('#dashboard_bundle_service_type_save')->click();
$services = $this->getServiceRepository()->findAll();
$this->assertCount(3, $services);
$this->assertCount(4, $services);
}
}

0 comments on commit 89bee6d

Please sign in to comment.