Set column name to createdAt

The default name is in conflict with our undrescore naming strategy. It was either adding a new migration, or fixing it like this. I opted for this solution.
SURFnet · Jun 17, 2024 · e77a766 · e77a766
1 parent 82aff57
commit e77a766
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/ci/qa/phpstan-baseline.php b/ci/qa/phpstan-baseline.php
@@ -2661,6 +2661,11 @@
 	'count' => 1,
 	'path' => __DIR__ . '/../../src/Surfnet/ServiceProviderDashboard/Domain/Entity/Service.php',
 ];
+$ignoreErrors[] = [
+	'message' => '#^Property Surfnet\\\\ServiceProviderDashboard\\\\Domain\\\\Entity\\\\Service\\:\\:\\$createdAt is unused\\.$#',
+	'count' => 1,
+	'path' => __DIR__ . '/../../src/Surfnet/ServiceProviderDashboard/Domain/Entity/Service.php',
+];
 $ignoreErrors[] = [
 	'message' => '#^Property Surfnet\\\\ServiceProviderDashboard\\\\Domain\\\\Entity\\\\Service\\:\\:\\$institutionId \\(string\\) does not accept string\\|null\\.$#',
 	'count' => 1,
@@ -3416,6 +3421,11 @@
 	'count' => 1,
 	'path' => __DIR__ . '/../../src/Surfnet/ServiceProviderDashboard/Infrastructure/DashboardBundle/Controller/PrivacyQuestionsController.php',
 ];
+$ignoreErrors[] = [
+	'message' => '#^Cannot call method getContact\\(\\) on Symfony\\\\Component\\\\Security\\\\Core\\\\User\\\\UserInterface\\|null\\.$#',
+	'count' => 1,
+	'path' => __DIR__ . '/../../src/Surfnet/ServiceProviderDashboard/Infrastructure/DashboardBundle/Controller/ServiceConnectionsController.php',
+];
 $ignoreErrors[] = [
 	'message' => '#^Method Surfnet\\\\ServiceProviderDashboard\\\\Infrastructure\\\\DashboardBundle\\\\Controller\\\\ServiceConnectionsController\\:\\:myServices\\(\\) has no return type specified\\.$#',
 	'count' => 1,

diff --git a/src/Surfnet/ServiceProviderDashboard/Application/Service/ServiceConnectionService.php b/src/Surfnet/ServiceProviderDashboard/Application/Service/ServiceConnectionService.php
@@ -89,6 +89,9 @@ private function addIdpList(EntityConnectionCollection $collection): void
         $collection->addIdpList($this->listTestIdps());
     }
 
+    /**
+     * @param array<string, IdentityProvider> $testIdpsIndexed
+     */
     private function addEntitiesToCollection(
         EntityConnectionCollection $collection,
         InstitutionId $institutionId,
@@ -150,6 +153,9 @@ private function addEntitiesToCollection(
         $collection->addEntityConnections($list);
     }
 
+    /**
+     * @return array<string, IdentityProvider>
+     */
     private function getTestIdpsIndexed(): array
     {
         // First create an indexed list of the test entities

diff --git a/src/Surfnet/ServiceProviderDashboard/Domain/Entity/Service.php b/src/Surfnet/ServiceProviderDashboard/Domain/Entity/Service.php
@@ -27,7 +27,8 @@
 
 /**
  * @SuppressWarnings(PHPMD.TooManyFields)
- * @SuppressWarnings(PHPMD.UnusedPrivateField) It is used to indicate the age of a service. See: https://www.pivotaltracker.com/story/show/187715470
+ * @SuppressWarnings(PHPMD.UnusedPrivateField) - the createdAt field is not used in code, but used by TPM's to check for
+ *                                               the creation date of a service.
  */
 #[ORM\Entity(repositoryClass: ServiceRepository::class)]
 class Service