Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the production_entities_enabled feature #1293

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Restore the production_entities_enabled feature #1293

merged 4 commits into from
Oct 31, 2024

Conversation

johanib
Copy link
Contributor

@johanib johanib commented Oct 31, 2024 •
edited
Loading

Please note the individual commits for context and scope to make reviewing easier.

Restores feature deleted in #628
See https://www.pivotaltracker.com/n/projects/1400064/stories/187053888

@johanib
Revert "Remove the production_entities_enabled field"
9520531 
This reverts commit a03baf4
@johanib
Revert "Remove project references to production ent enabled"
28faeb0 
This reverts commit 828cb49
@johanib
Revert "Remove prod-ent-enabled references from tests"
48f0ba6 
This reverts commit d3714df.
@johanib
Repair the production_entities_enabled feature
c1bdcef 
Prior to this change, the production_entities_enabled field could be deleted from the services table.
This change cleans up after the migration got retracted.
Also add the required param to the tests.
@johanib johanib requested a review from MKodde October 31, 2024 11:28
MKodde
MKodde approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From code review perspective this looks great! I did not have the opportunity to functionally test this feature. Will try that now

@johanib johanib mentioned this pull request Oct 31, 2024
Open
@johanib
Copy link
Contributor Author

johanib commented Oct 31, 2024

Resolves #1145

@johanib
Copy link
Contributor Author

johanib commented Oct 31, 2024

Discussed with Michiel. He could not test because his env would not start.
I tested the migration on my machine, and both scenario's work.
The button also works.

Merging.

@johanib johanib merged commit 3c9a726 into main Oct 31, 2024
3 checks passed
@johanib johanib deleted the feature/revert-187053888 branch October 31, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKodde MKodde MKodde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanib @MKodde