Add createdAt to Service entity
#636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parijke
requested changes
Jun 12, 2024
| */ | ||
| #[Gedmo\Timestampable(on: 'create')] | ||
| #[ORM\Column(type: 'datetime')] | ||
| private DateTime $created; |
There was a problem hiding this comment.
Isn't it better to rename this to createdAt
There was a problem hiding this comment.
It's a better name, thanks for the suggestion.
This additional field will show us when a service is created. See: https://www.pivotaltracker.com/story/show/187715470
MKodde
force-pushed
the
feature/service-createdate
branch
from
142ba71
to
a5b18e4
Compare
parijke
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additional field will show us when a service is created. It is not displayed anywhere in the UI (by design). It is just there for the TPMs to inform them for how long the SP has been granted access to the dashboard.
See: https://www.pivotaltracker.com/story/show/187715470