Hide nameIdFormat when unspecified
#668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the 'subjectType' or 'nameIdFormat' is unspecified. The matching form field is not displayed on the form. That way we do not allow the user to overwrite this value in Manage (which is explicitly set for that SP by a product owner) To test this, the mock SP storage needed to track the nameIdFormat value as a manage entity. That requires quite some test code to be edited.. See: https://www.pivotaltracker.com/story/show/185952423
parijke
approved these changes
Aug 14, 2024
Comment on lines
+328
to
340
|
|
||
| // When the SAML2.0 entity is set to have an UNSPECIFIED name id format (in manage) do not show the field on the form | ||
| $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event): void { | ||
| /** @var SaveSamlEntityCommand $data */ | ||
| $data = $event->getData(); | ||
| if ($data->getNameIdFormat() === Constants::NAME_ID_FORMAT_UNSPECIFIED) { | ||
| $form = $event->getForm(); | ||
| if ($form->has('metadata') && $form->get('metadata')->has('nameIdFormat')) { | ||
| $form->get('metadata')->remove('nameIdFormat'); | ||
| } | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
It's not realy a dry thing in my opinion; the one block deals with the nameIdFormat and the other with the clientId. They kind-of are the same thing. Leaving it as is for now
| '12', | ||
| Constants::NAME_ID_FORMAT_UNSPECIFIED | ||
| ); | ||
| $crawler = self::$pantherClient->request('GET', "/entity/edit/test/88888888-1111-1111-1111-888888888888/1"); |
There was a problem hiding this comment.
This does not have to be with a full blown panther instance I guess, could also be done with lightweigth kernelbrowser
There was a problem hiding this comment.
True, only thing is we only have a panther based test setup. This could be a nice optimization we could look into. Although the performance gain is not that big IIRC from when we chose to move to Panther.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the 'subjectType' or 'nameIdFormat' is unspecified. The matching form field is not displayed on the form. That way we do not allow the user to overwrite this value in Manage (which is explicitly set for that SP by a product owner)
To test this, the mock SP storage needed to track the nameIdFormat value as a manage entity. That requires quite some test code to be edited..
See: https://www.pivotaltracker.com/story/show/185952423