Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detailed revision note when editing an entity #669

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Add detailed revision note when editing an entity #669

merged 3 commits into from
Aug 15, 2024

Conversation

MKodde
Copy link
Contributor

@MKodde MKodde commented Aug 12, 2024

@MKodde MKodde requested a review from parijke August 12, 2024 09:10
parijke
parijke approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@parijke parijke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise ok. The only thing is a lot of repetition, but that is a know issue in these generator classes

@MKodde MKodde merged commit c5fe698 into main Aug 15, 2024
2 of 3 checks passed
@MKodde MKodde deleted the feature/test-entity-revision-note branch August 15, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parijke parijke parijke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MKodde @parijke